Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scene trigger on device change, threshold not clickable #1819

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix scene trigger on device change, threshold not clickable #1819

merged 2 commits into from
Jun 30, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #1815

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 26, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b69bb37
Status: ✅  Deploy successful!
Preview URL: https://f42c4bf2.gladys-plus.pages.dev
Branch Preview URL: https://fix-scene-threshold-change.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Jun 26, 2023 •
edited

Job #1610: Bundle Size — 8.51MiB (~+0.01%).

68d9c13(current) vs b19cff3 master#1608(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1610		      Baseline
Job #1608
Initial JS 4.58MiB(~+0.01%) 4.58MiB
Initial CSS 301.69KiB 301.69KiB
Cache Invalidation 53.67% 0%
Chunks 47 47
Assets 149 149
Modules 1343 1343
Duplicate Modules 19 19
Duplicate Code 0.68% 0.68%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1610		      Baseline
Job #1608
CSS 314.99KiB 314.99KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.89MiB 1.89MiB
JS 6.19MiB (~+0.01%) 6.19MiB
Media 0B 0B
Other 15.21KiB 15.21KiB

View job #1610 report View master branch activity

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b19cff3) 97.83% compared to head (b69bb37) 97.83%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         711      711           
  Lines       10951    10951           
=======================================
  Hits        10714    10714           
  Misses        237      237

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 68d9c13 into master Jun 30, 2023
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-scene-threshold-change branch June 30, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scene bug: impossible to uncheck "Execute only when threshold is passed"
1 participant
@Pierre-Gilles